fix(attestation): base64 encode inline helm charts#2690
Closed
Piskoo wants to merge 1 commit intochainloop-dev:mainfrom
Closed
fix(attestation): base64 encode inline helm charts#2690Piskoo wants to merge 1 commit intochainloop-dev:mainfrom
Piskoo wants to merge 1 commit intochainloop-dev:mainfrom
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Member
|
Thanks but I think this is an issue that affects inline items in general not just Helm Charts #2065 |
Collaborator
Author
Correct, but it is a small change that would enable it for Helm Charts, without breaking anything like using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm chart tarballs stored inline within attestation now are encoded with base64, this fixes issue with UTF-8 validation.
Part of the returned attestation
Closes #2685